Closed
Bug 1157447
Opened 10 years ago
Closed 7 years ago
TSan: data race js/src/vm/Shape.h:826 setOverwritten
Categories
(Core :: JavaScript Engine: JIT, defect, P3)
Tracking
()
RESOLVED
DUPLICATE
of bug 1458008
People
(Reporter: froydnj, Unassigned)
References
(Blocks 1 open bug)
Details
(Whiteboard: [tsan])
Attachments
(1 file)
16.96 KB,
text/plain
|
Details |
The attached logfile shows a thread/data race detected by TSan (ThreadSanitizer).
* Specific information about this bug
Filing this under JS: JIT because of the reading stack containing lots of js::jit:: things.
It looks like we can touch js::Shape::flags on multiple threads without locking.
* General information about TSan, data races, etc.
Typically, races reported by TSan are not false positives, but it is possible that the race is benign. Even in this case though, we should try to come up with a fix unless this would cause unacceptable performance issues. Also note that seemingly benign races can possibly be harmful (also depending on the compiler and the architecture) [1][2].
If the bug cannot be fixed, then this bug should be used to either make a compile-time annotation for blacklisting or add an entry to the runtime blacklist.
[1] http://software.intel.com/en-us/blogs/2013/01/06/benign-data-races-what-could-possibly-go-wrong
[2] _How to miscompile programs with "benign" data races_: https://www.usenix.org/legacy/events/hotpar11/tech/final_files/Boehm.pdf
Updated•9 years ago
|
Priority: -- → P3
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•